Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shadow DOM or different class names #3

Open
RaminGe opened this issue Jul 21, 2023 · 1 comment
Open

Use shadow DOM or different class names #3

RaminGe opened this issue Jul 21, 2023 · 1 comment

Comments

@RaminGe
Copy link

RaminGe commented Jul 21, 2023

Hey there,

It would make lots of sense to add the image viewer as shadow DOM element instead of just adding it to the body, or at least rename the classes and add some suffix or prefix. Right now the viewer uses the class name container which is widely used by many css libraries and can infer with the styles of the image viewer.

E.g. in this case the container class has a max width set globally and therefore also limits the image viewer (which of cource should still be displayed in fullscreen):
img-viewer-width

This could be resolved by renaming the classes used to e.g. ìmg-viewer-container or use the shadow DOM.

@MostafaMDZH
Copy link
Owner

Hi @RaminGe
That's a great idea! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants