-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Causing funny ui issues with journeymap. #109
Comments
After looking into this, it seems like my screen change detection system is unable to handle the fact that you're rendering two screens at the same time. When a screen change is detected and the new screen (in this case your layered one) does not appear to have blur, the fade out effect manually renders blur and writes the framebuffer, which is likely the cause of the text glitching: |
I'll see if I can find a solution that keeps the current behavior while taking nested screens into account. |
With the latest version, we do not call minecraft.setScreen if there is a background screen. That might be helpful. This layered screen mimics a lot of what the vanilla RealmsPopupScreen does. I imagine other mods use a similar thing if they layer screens. |
So, I draw screens on top of each other with a z translation of 2000.
With your mod installed, it does this.
it should look like this.
This is my layering logic
https://github.com/TeamJM/journeymap-api/blob/56b6778a4bfebfee80ed10673988ee5809b5bfe4/common/src/main/java/journeymap/api/v2/client/ui/component/LayeredScreen.java#L47
I am curious what you are doing that is causing this? I can increase the z translation to 2001 and it fixes it. But, that only fixes it on my end with my mod. This is likely causing compatibility issues with other mods too, so we should come up with a solution that fix it at the source.
The text was updated successfully, but these errors were encountered: