-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resort visitors #15
Comments
Some other things I noticed in comparison: For Marnie, ILSpy has : And Robin should have the hospital visit on day 46, but you had 44. But even after these fixes it still isn't entirely correct. So I'm investigating more. |
And I think I may have found the issue, and quickly skimming the code I think this is the only place it will appear, and it directly relates to the first point I found. Javascript using 64 bits for these numbers, but c# only uses 32 bits. This causes rounding errors for the generation of the seed. I'll check to see if this works over the next few days in game |
And checking, it works for the current day (i.e. the day the save is when it is loaded into the predictor), and it works for groups. |
I notice that you have resort visitors in the file but aren't displaying it.
I was looking into it and noticed that the code you have doesn't match that produced by ILSpy.
You have:
1.21*save.gameID + 2.5*(day + save.dayAdjust)
As the seed for the random number generator, but the code produced by ILSpy converts these both to integers before combining them, which produces a different result.
Could that be the cause of why it appears so random?
The text was updated successfully, but these errors were encountered: