Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two objects placed inside of themselves #299

Open
NicholasBatesNZ opened this issue Jun 13, 2018 · 1 comment
Open

Two objects placed inside of themselves #299

NicholasBatesNZ opened this issue Jun 13, 2018 · 1 comment
Labels

Comments

@NicholasBatesNZ
Copy link
Member

NicholasBatesNZ commented Jun 13, 2018

This issue is the culmination of everything contained in the issues #54 #56 and #117. Each individual issue identified what was thought to be an independent issue of Asteroids spawning inside of each other and then star ports doing the same thing. After witnessing myself two ships stuck inside of each other, it is clear that we have a more general placement issue rather than what was initially thought.

screen_shot_2018-02-28_at_10 44 03_am

#90 was merged as a band aid fix for #56 and #238 attempted to do the same thing but for #54
What needs to be done now is investigate the placement logic (this can be started by looking at those PRs) and find a more general solution.

"I've come across an asteroid that was stuck within a much larger asteroid today, sadly bouncing around, unable to escape his captor." - grauerkoala

"When the counterparts of two star ports are somewhat close to each other, those star ports can overlap in such a bad way that it's not possible to tell which one you end up in.
I'm guessing that this has to do with the general concept of the positioning of star ports in relation to their home planet, which may require some (but not too much) rethinking of said concept." - grauerkoala

"The placement logic seems able to flip out if there are three star gates too close together. Original report on Google+ by saya orang. Probably happens rarely enough to have hidden this long. May need to tweak at the solar system config to try replicating it." - Cervator

@Adrijaned
Copy link
Member

Also, StarPorts might spawn basically at the spawnpoint. Someone look into the placement logic for that too, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants