New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signalReload can't be called immediately after createHiddenService/saveConfig #5

Open

mattcollier opened this issue Mar 24, 2015 · 1 comment

Contributor

mattcollier commented Mar 24, 2015

I have prepared a test kit for this issue here: https://gist.github.com/mattcollier/5703ae124c2bc14653ab

The provided code functions as expected, however if myDelay=0, the callback on getOnionAddress is never executed.

So, it would seem that saveConfig needs a callback as well?

Member

abenmrad commented Mar 24, 2015

Ok, I get what you mean. The are 2 weird things in this bug:

There are only synchronous methods used in saveConfig
The methods that offer an applyNow parameter, when set to true, execute saveConfig and signalReload one after the other, without any callback from saveConfig and what not. And this works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment