Leave when inventory lacks fishing rods and moving for MCMMO compatability

[BlitzTheSquishy]

as the title says, though the bot does come up with "no longer has fishing rods" then "I have a fishing rod" although i have 10 or so in my inventory a delay from having a fishing rod would be nice to have. Also due to MCMMO is a plugin I'm testing this on, having the bot be able to move to avoid "overfished" areas would be nice too.

[MrKinau]

I've noted the first suggestion. The other point you mentioned most-likely wont get implemented, because for moving the bot needs to know their surrounding and Pathfinding to find another fishing spot. This is not in the scope of this bot.

[Artoria2e5]

The McMMO thing also affects autofish in MrTroot/autofish#24. The proposed solution is to just assume there's enough water 360 degrees around and rotate (yaw) on the spot. I think the packet is something like https://github.com/PrismarineJS/mineflayer/blob/101297f632dd40026e8777e9f9ef41477ed99b37/lib/plugins/physics.js#L89-L97. No idea about boat turning.

[Artoria2e5]

Oh, looks like we already have a /look command. That would be enough for the most simplistic way to do it -- in fact if you have something like AutoHotKey or a pipe in nogui mode to do a bit of yaw periodically, you are already golden!

Of course for the less tech-inclined you need to give a bit more. For the 360 degree case all you need is an amount to advance per catch. Although it would be neat to get a yaw range setting so you can fish on a normal hoppered riverbank.

And man the windows nogui experience is shit. There's no echo on the input so you type blind!

[Artoria2e5]

Anyways, here's the rlwrap toy script: https://gist.github.com/Artoria2e5/deafa5c4da21bb62437820444124ef48

Copilot wrote most of it. It works on Windows MSYS2 after you get the PATH right, that I know.

Using a program to tell a program to tell a program to do things. That's bot-ception.

---

(This shit does work, but the thing with McMMO is that you don't get fishing rods from fishing for "balance". You got make a mending rod yourself to keep it going, but I suppose you know that already. Just... no more of that one-rod rags to riches from fishing story.)

[CookieGMG]

I've noted the first suggestion. The other point you mentioned most-likely wont get implemented, because for moving the bot needs to know their surrounding and Pathfinding to find another fishing spot. This is not in the scope of this bot.

you could possibly use baritone for pathfinding, not sure if it is the best solution though