Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonrpc websocket api header not handled case insensitive #74

Open
L-Henke opened this issue Jan 18, 2021 · 2 comments
Open

jsonrpc websocket api header not handled case insensitive #74

L-Henke opened this issue Jan 18, 2021 · 2 comments
Assignees

Comments

@L-Henke
Copy link

L-Henke commented Jan 18, 2021

I found a problem with the handling of headers in a websocket connection to the json-rpc API. I'm using Home Assistant to connect to the API of MrMC. A recent change in the used aiohttp library broke this connection, because aiohttp changed a header from Connection: Upgrade to Connection: upgrade. This is compliant to the RFC which states, that this variable should be treated case-insensitive.

Current versions of Kodi are working fine with the changed header, but if you connect to MrMC, the connection runs into a timeout.

The jsonrpc version of MrMC seems to be way behind the upstream Kodi version, but maybe it is possible to upgrade your version or change the parsing of the connection headers to be case-insensitive.

@amet
Copy link
Collaborator

amet commented Jan 24, 2021

should be fixed in the next version, we will push the TestFlight version with it soon.

what platform are you running MrMC on?

@amet amet self-assigned this Jan 24, 2021
@L-Henke
Copy link
Author

L-Henke commented Jan 24, 2021

I'm running MrMC on an Apple TV 4K.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants