Tabs on bottom messed up in Developer 133.0b1

[plissken1138]

Tabs on bottom messed up in Developer 133.0b1

It was working fine up until latest update. Now tabs are back on top of everything.
In addition to that,, not to make only one thing annoying,
clicking into address bar now opens it to the whole width of the screen...

[plissken1138]

looks like tabs_on_bottom_v2 still works.

address bar fixed when I removed megabar-tweaks.css

[MrOtherGuy]

Yeah, there's a couple of these "v2" styles that will replace the old ones in 133 onwards. I want to preserve the old ones though for the lifetime of the ESR 128 cycle so for now there are two versions.

[madeddy]

Not sure if this fits here or should i make a new ish?

The "tabs_on_bottom_v2.css" does work for me in the v133 release and I'm in Kubuntu 22.04.5. I use it as import and have the two other snippeds i use even outcommented for test purpose.
userchrome.css:

/*@import url(window_control_placeholder_support.css);
@import url(linux_gtk_window_control_patch.css);*/
@import url(/chrome/tabs_on_bottom_v2.css);

/* Your other/personal rules here */

toolkit.legacyUserProfileCustomizations.stylesheets is also set to true

[artemlive]

It's the same to me.
tabs_on_bottom_v2.css
133.0 (aarch64)

[CurePindal]

Edit: Fixed.
tabs_on_bottom_v2 doesnt work with window_control_placeholder_support.css together!

tabs_on_bottom_v2 messes up the buttons for me (fullscreen and reduced):

Thats whats called "buttonbox" thats misaligned, right?

Anybody an idea whats wrong?
I only use:
@import url(window_control_placeholder_support.css);
@import url(tabs_on_bottom_v2.css);

[madeddy]

Update: Tabs on bottom works now for me with:

import url(window_control_placeholder_support.css);
import url(tabs_on_bottom_v2.css);

I think i had a "copy and past" issue, where at pasting of the *_v2 content the line indent was messed up.

However, i have now also the additional space on my addressbar(as @CurePindal) if thats related to this css snipped.

[MrOtherGuy]

Hey dudes, do not use window_control_placeholder_support.css with tabs_on_bottom_v2 - you do not need it. Whatever it may cause is completely unintentional.

[artemlive]

What am I doing wrong?
userChrome.css:
import url(chrome/tabs_on_bottom_v2.css);

toolkit.legacyUserProfileCustomizations.stylesheets true

and it doesn't work
133.0 (aarch64)

[madeddy]

@CurePindal This strange "space" in the addressbar is only from use of window_control_placeholder_support.css and IMO not related. On my sys this happens also if i use this without tabs_on_bottom_v2.css.

@artemlive Did you check your copied/downloaded tabs_on_bottom_v2.css if everything correct is with the file content etc?

[MrOtherGuy]

What am I doing wrong? userChrome.css: import url(chrome/tabs_on_bottom_v2.css);

toolkit.legacyUserProfileCustomizations.stylesheets true

and it doesn't work 133.0 (aarch64)

Import syntax is started with @import so try that. See https://developer.mozilla.org/en-US/docs/Web/CSS/@import

[artemlive]

@MrOtherGuy ty for the reply.
It doesn't work.

pwd
/Users/myuser/Library/Application Support/Firefox/Profiles/lezmnfkg.default-release

cat chrome/userChrome.css --style=plain                                                                                                                              
@import url(chrome/tabs_on_bottom_v2.css);

ls chrome/chrome/tabs_on_bottom_v2.css                                                                                                                            
chrome/chrome/tabs_on_bottom_v2.css

[artemlive]

@madeddy, thanks for your reply. Yes, I checked, and the file is correct.
I don't want to post the whole file, so (I run it within the root profile's directory, so there is the "chrome" directory twice):

cat chrome/chrome/tabs_on_bottom_v2.css | wc -l
      52

I've also tried to make a mistake in it to check if the FF tries to load it, and it does.

[MrOtherGuy]

I don't want to post the whole file, so (I run it within the root profile's directory, so there is the "chrome" directory twice):

Note that all @import statements must be placed before any other rules in the file otherwise the import is ignored.

[artemlive]

I don't want to post the whole file, so (I run it within the root profile's directory, so there is the "chrome" directory twice):

Note that all @import statements must be placed before any other rules in the file otherwise the import is ignored.

I get that, thanks. My userChrome.css file has only one line: @import url(chrome/tabs_on_bottom_v2.css);

[artemlive]

Hmm, I see that in the default style, it looks like this:

But If I include the tabs_on_bottom_v2.css:

So, it moves under the address bar but not to the bottom of the window.

[MrOtherGuy]

Right, well tabs_on_bottom.css (and tabs_on_bottom_v2.css by extension) is supposed to move tabs as the bottom-most toolbar. So I take it that it does work?

If you want tabs below content, then use tabs_below_content_v2.css

@CurePindal can you confirm that tabs_on_bottom_v2.css works for you as well after you remove anything that has to do with old tabs_on_bottom.css and window_control_placeholder_support.css?

[artemlive]

Right, well tabs_on_bottom.css (and tabs_on_bottom_v2.css by extension) is supposed to move tabs as the bottom-most toolbar. So I take it that it does work?

If you want tabs below content, then use tabs_below_content_v2.css

@CurePindal can you confirm that tabs_on_bottom_v2.css works for you as well after you remove anything that has to do with old tabs_on_bottom.css and window_control_placeholder_support.css?

The problem was that I misinterpreted the tabs_on_bottom_v2.css as a replacement for the tabs_on_bottom.css that I used for moving the tabs to the bottom of the window (below content) before the latest upgrade.
I can confirm that everything works as expected. Thanks, and sorry for the mess.

[MrOtherGuy]

No worries, although I don't know what you had done previously, but tabs_on_bottom.css never moved tabs below content. Perhaps you had code from old tabs_below_cotent.css but labelled it as if it was tabs_on_bottom.

Who knows, main thing is that things works fine now.

[Laephis]

Starting to pull my hair out over this, but I've read through this thread multiple times and I still can't get tabs_on_bottom_v2.css working no matter what I do. I have my userChrome.css file looking like this:

@import url(tabs_on_bottom_v2.css);

and toolkit.legacyUserProfileCustomizations.stylesheets set to true but no effect. I'm just updating a previously working tweak, which I've been doing for years now since FF devs refuse to give us this option built-in.

Am I just missing something painfully obvious?

[MrOtherGuy]

@Laephis you could try just copying the contents of tabs_on_bottom_v2.css directly into userChrome.css to rule out any issues from potentially incorrect use of @import. For good measure, also remove everything else in your userChrome.css file - just copy things temporarily to somewhere else.

[MrOtherGuy]

Please keep this issue about tabs_on_bottom.css and open new issues about unrelated things.

[Laephis]

@Laephis you could try just copying the contents of tabs_on_bottom_v2.css directly into userChrome.css to rule out any issues from potentially incorrect use of @import. For good measure, also remove everything else in your userChrome.css file - just copy things temporarily to somewhere else.

Hi and thanks for the troubleshooting suggestion. I tried putting the css code directly into the userChrome.css file but it didn't have an effect either. Just to be sure I wasn't losing my mind, I used an old Windows laptop, updated to FF 133 and modified the userChrome file the same way - and it works perfectly.

Would the fact that I'm using a flatpak version of FF on Linux (Bazzite to be exact, an immutable version of Fedora) have any kind of effect? The code should work independent of the OS, correct?

UPDATE: Yes, it was a Flatpak issue. Turned out I needed to use Flatseal to modify FF permissions so that it would use the correct profile that's listed in about:profiles. Everything working as intended now. Thanks again.

[MrOtherGuy]

Okay, glad you sorted that out. But in addition to issues that are simply about loading the file such was the case here, you should know that there is also quite a lot of platform dependent styles and some other differences in Firefox so there is very much a possibility for styles not behaving the same across systems.

Moreover, various LInux distributions are known to add their own changes into Firefox and pushing the modified version to their package manager. Those changes could be anything and I cannot really account for whatever random stuff they might do - thus I would recommend that if you are customizing Firefox then you should get your build directly from Mozilla instead of your package manager.