Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.12.2 - Clouds Pass Through Buildings/Structures and Crops Lose Their Model When FoliageShaders Enabled #191

Open
KenyMylankca opened this issue Apr 28, 2024 · 8 comments
Assignees
Labels
Bug Something isn't working

Comments

@KenyMylankca
Copy link

Hello :)
I tried everything but clouds always pass through everything, I made a home inside a mountain and it's very cloudy inside...
and crops... just enable foliageshaders option, and you will see purple&black particles if you destroy some flowers or weeds or any crop, and also, wheat on a farmland is completely purple&black if the foliageshaders is on.

I'm playing in my modpack but these bugs are reproducible in vanilla too, I just tried; except the farmland one, I think harvestcraft or some other mods tweaking the wheat on the farmland so they lose their models, if foliageshaders is on.

we'll be lovely happy if these bugs be fixed ^^

kind regards,
kenijey

forge2860
coroutil-1.12.1-1.2.37
Weather2Remastered-1.12.2-2.8.11
config.zip

2024-04-28_13 03 44
2024-04-28_13 03 39

@KenyMylankca KenyMylankca added the Bug Something isn't working label Apr 28, 2024
@KenyMylankca
Copy link
Author

KenyMylankca commented Apr 28, 2024

you can also contact me in Discord(kenijey) if you have any questions, i might help with the code too.

@KenyMylankca
Copy link
Author

2024-04-28_13 19 18
and this is from my modpack, the farmland one.

@Mrbt0907
Copy link
Owner

Ooh yeah that is not right at all. Thank you for reporting the bug. I'll figure out what causes this when I have time to modify the foliage shaders. As for the cloud issue, I just have to reduce the size of cloud particles and improve their hit detection.

@KenyMylankca
Copy link
Author

oh also, sometimes the foliage thing appears on weird crops too.
2024-04-29_13 38 49
I mean modded grass blocks are fine, but not crops xD

@Mrbt0907
Copy link
Owner

That is really weird. That means there's a mod interfering with the rendering process. I'll check it out when i can, but I don't know if I am skillful enough to fix it.

@KenyMylankca
Copy link
Author

That is really weird. That means there's a mod interfering with the rendering process. I'll check it out when i can, but I don't know if I am skillful enough to fix it.

It's ok, i'm sure it's pam's harvestcraft that tweaks all crops by default, i will find it out today when im home. If you get stuck in code i can help too, maybe i wll make a pull request after a fork idk.

@Mrbt0907
Copy link
Owner

It'll be a while before I start tweaking the folliage shaders, so if you want to fix it and do that, feel free to do so.

@KenyMylankca
Copy link
Author

Ok the only problem is with vanilla wheat crop, all the rest are fine.
2024-05-06_14 40 56
so 3 bugs:
-destroying crops particles black&purple (missing idk)
-vanilla wheat crop renders ok, but has an extra black&purple thing on/in it
-sometimes extra grass gets rendered on modded crops like harvestcraft garden(just make the code to check if it is a full block)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants