Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion]: Villager Trades functionality enhancement!! #11

Open
1 of 3 tasks
InFuRiTy opened this issue Jun 16, 2023 · 3 comments
Open
1 of 3 tasks

[Suggestion]: Villager Trades functionality enhancement!! #11

InFuRiTy opened this issue Jun 16, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@InFuRiTy
Copy link

General Info

  • I would like to propose new content
  • I would like to propose changes
  • I would like to propose another thing

Suggestion Description

Are you considering/have plans to add support for detailed trade jobs info for villager professions?

There are no new mods for 1.19 and upwards that have this feature apart from this REI addon : Roughly Enough Trades, which of course JEI doesn't support.
Trying to remember what each villager sells is a pain in the rear. That or having to look through wikis which is even a bigger pain.
Especially when mods add their own villager trades!
I might be a dum-dum about it and i don't search properly or look hard enough but i can't find anything close to that.
So i was just wondering since your mod seems quite popular in recent Forge packs that I've played!!

@InFuRiTy InFuRiTy added the enhancement New feature or request label Jun 16, 2023
@Mrbysco
Copy link
Owner

Mrbysco commented Jun 16, 2023

I've thought about it and even have a branch where I've attempted it but it added half a minute of load time to the world load so I've yet to re-attempt and improve performance

@InFuRiTy
Copy link
Author

I've thought about it and even have a branch where I've attempted it but it added half a minute of load time to the world load so I've yet to re-attempt and improve performance

Good to hear you're trying at least!!! Take all the time you need!!

@InFuRiTy
Copy link
Author

InFuRiTy commented Jun 20, 2023

Here's an idea!!

How about pre-generating a file/database/script or a code block that contains all job trade variations on client load instead of searching and loading them on world/server join?
Since the job trades that each villager has are static and no dynamic to the point of breaking everything, they could all be ready and up for access already from a generated source.

Unless the server has a say in this, then it becomes troublesome.
I have zero coding knowledge for this, im just putting ideas out!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants