Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra separator to links in H2 #328

Open
vlad-timotei opened this issue Sep 16, 2021 · 2 comments · Fixed by #337
Open

Add extra separator to links in H2 #328

vlad-timotei opened this issue Sep 16, 2021 · 2 comments · Fixed by #337
Labels
enhancement hacktoberfest

Comments

@vlad-timotei
Copy link
Collaborator

Case 1: project doesn't have Glossary, but User is GTE/PTE and sees "Create a Glossary" link
image

Case 2: project has a Glossary and user can have any role.
image

Case 3: project doesn't have a Glossary, user is not GTE/PTE => all good.
image

We need to find a way to append/prepend these extra links with a | where applicable, because there is case 3.

Reported by: @NekoJonez
@vlad-timotei vlad-timotei mentioned this issue Sep 22, 2021
Merged
@vlad-timotei
Copy link
Collaborator Author

vlad-timotei commented Sep 22, 2021 •
edited
Loading

Fixed in #337

@NekoJonez
Copy link
Contributor

NekoJonez commented Oct 28, 2021 •
edited
Loading

I think we should reopen this since

image

Import translations has a missing one.
@vlad-timotei

@vlad-timotei vlad-timotei reopened this Oct 28, 2021
@vlad-timotei vlad-timotei mentioned this issue Feb 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve the readability of h2 on translation pages
3 participants
@Mte90 @NekoJonez @vlad-timotei