Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shizuku support for ADB privilege #55

Closed
Cyberavater opened this issue Aug 5, 2020 · 8 comments
Closed

Add shizuku support for ADB privilege #55

Cyberavater opened this issue Aug 5, 2020 · 8 comments
Labels
Documentation Improvements or additions to documentation Feature New feature or request Status: Rejected This will not be worked on

Comments

@Cyberavater
Copy link

It would be nice if non-root user could use Shizuku for ADB privilege
https://github.com/RikkaApps/Shizuku

@MuntashirAkon MuntashirAkon added the Feature New feature or request label Aug 5, 2020
@MuntashirAkon
Copy link
Owner

MuntashirAkon commented Aug 16, 2020

I'm not sure if I will do that. RikkaApps doesn't have a license for Shizuku and the related issue (RikkaApps/Shizuku/issues/56) is closed without any comment. They've also declined to publish their app on F-Droid (RikkaApps/Shizuku/issues/69) which they can't because the app doesn't have any license (Even if I want, I can't even fork the app to provide a release on F-Droid for the same reason). They do have a license for their API but, I have to say, the whole thing is a bit shady and being a strong supported of freedom, I'm not going to support Shizuku.

I do have plan to work more on ADB and reflection to make the process a bit easier. In future, I'll also support installing App Manager as a system app (which can be built with custom ROMs), which won't be requiring any root for most tasks.

In short, due to Shizuku's policy (which is a non-free software) and my roadmaps, I can't add support for Shizuku.

@MuntashirAkon MuntashirAkon added the Status: Rejected This will not be worked on label Aug 16, 2020
@Cyberavater
Copy link
Author

Understandable.

@MuntashirAkon MuntashirAkon added the Documentation Improvements or additions to documentation label Aug 16, 2020
@MuntashirAkon
Copy link
Owner

A more formal answer is given here: https://muntashirakon.github.io/AppManager/faq/misc.html#any-plans-for-shizuku

@Pandapip1
Copy link

Pandapip1 commented May 31, 2023

Shizuku is now licensed under Apache-2. I suggest this or #55 be reopened

@MuntashirAkon
Copy link
Owner

Shizuku is now licensed under Apache-2. I suggest this or #55 be reopened

Shizuku is still non-free due to its ToS. OSI license is not enough to judge if a software is free. It must not adhere to any additional terms that might make it non-free.

@Pandapip1
Copy link

Fair enough.

@e-t-l
Copy link

e-t-l commented May 12, 2024

A more formal answer is given here: https://muntashirakon.github.io/AppManager/faq/misc.html#any-plans-for-shizuku

This leads to an empty 404 error page

Shizuku is now licensed under Apache-2. I suggest this or #55 be reopened

Shizuku is still non-free due to its ToS. OSI license is not enough to judge if a software is free. It must not adhere to any additional terms that might make it non-free.

I won't pretend to understand the license legalese, and I don't really know what "non-free" means in this context, but the Shizuku-API, which is what would actually need to be included in the app, has a pretty straightforward and permissive MIT license as far as I can tell. Is that not sufficient? The best other non-root option for AppManager, wireless debugging mode, is pretty inconvenient since it requires a constant wifi connection. Shizuku avoids this issue by persisting beyond wifi disconnect.

@MuntashirAkon
Copy link
Owner

Latest explanation is available here: amcommunity/TipsAndTricks#14

@shuvashish76 shuvashish76 mentioned this issue May 30, 2024
3 tasks
@MuntashirAkon MuntashirAkon mentioned this issue Nov 16, 2024
3 tasks
@MuntashirAkon MuntashirAkon pinned this issue Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Feature New feature or request Status: Rejected This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants