Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add protocol handlers for PWA #547

Open
benthecarman opened this issue Sep 20, 2023 · 2 comments · May be fixed by #896
Open

Add protocol handlers for PWA #547

benthecarman opened this issue Sep 20, 2023 · 2 comments · May be fixed by #896
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@benthecarman
Copy link
Collaborator

Looks like we can have it so when we scan a QR outside the app, mutiny will be an option.

Should hook this up for lightning, bitcoin, and lnurlp

https://developer.mozilla.org/en-US/docs/Web/Manifest/protocol_handlers
@benthecarman benthecarman added the enhancement New feature or request label Sep 20, 2023
@benthecarman
Copy link
Collaborator Author

I think to do this we need to be able to do something like /send?param=somestring so we can load it that way

@benthecarman benthecarman added the good first issue Good for newcomers label Sep 20, 2023
@TonyGiorgio
Copy link
Collaborator

This would only be useful for chrome on android from what it looks like.

@elsirion elsirion mentioned this issue Nov 20, 2023
Open
@alpeb-btc alpeb-btc mentioned this issue Feb 21, 2024
Closed
alpeb-btc pushed a commit to alpeb-btc/mutiny-web that referenced this issue Feb 21, 2024
@alpeb
Add bitcoin protocol handler for PWA
085ef31 
Closes MutinyWallet#547

In my testing I could only make the `bitcoin` handler work. This is likely due to the ["safelisted schemes"](https://html.spec.whatwg.org/multipage/system-state.html#safelisted-scheme).
The `send?invoice=%s` url was already being handled by the `parsePaste` function but the invoice data wasn't getting picked up, so I had to add the `handleDestination` call in there.
alpeb-btc added a commit to alpeb-btc/mutiny-web that referenced this issue Feb 21, 2024
@alpeb-btc
Add bitcoin protocol handler for PWA
e6ce8b1 
Closes MutinyWallet#547

In my testing I could only make the `bitcoin` handler work. This is likely due to the ["safelisted schemes"](https://html.spec.whatwg.org/multipage/system-state.html#safelisted-scheme).
The `send?invoice=%s` url was already being handled by the `parsePaste` function but the invoice data wasn't getting picked up, so I had to add the `handleDestination` call in there.
@alpeb-btc alpeb-btc linked a pull request Feb 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add bitcoin protocol handler for PWA alpeb-btc/mutiny-web
Add bitcoin protocol handler for PWA
2 participants
@benthecarman @TonyGiorgio