Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Character Generator improperly displays modifiers in stat box #799

Closed
TheBrianFactor opened this issue May 17, 2024 · 2 comments · Fixed by #803
Closed

Bug: Character Generator improperly displays modifiers in stat box #799

TheBrianFactor opened this issue May 17, 2024 · 2 comments · Fixed by #803
Assignees
Labels
bug Something isn't working
Milestone

Comments

@TheBrianFactor
Copy link

As title suggests, using the Character Generator to roll a character, the "Stats" section improperly displays modifiers associated with the rolled ability score. See picture:
image
Proper scores should be:
STR: +3 (incorrect)
DEX: +3 (incorrect)
CON: 0 (correct)
INT: +1 (correct)
WIS: +2 (incorrect)
CHA: 0 (incorrect)

@ScoobyTchotchke
Copy link

It's worse than that it would seem. If you click to roll for stats, it doesn't take effect until you roll for any other field in the character generator. The first time I click on the dice icon for Stats, everything remains as 10's. It's not until I click on the dice for any other field in the Character Generator that it updates the stats to what I rolled. If I attempt to re-roll, it doesn't automatically update the select boxes, but the modifiers change to reflect the new rolls. I have to re-roll another field to get the stat values to show up properly.

@Muttley Muttley added the bug Something isn't working label May 25, 2024
@Muttley Muttley added this to the release-2.2.2 milestone May 25, 2024
@Muttley Muttley self-assigned this May 25, 2024
@PrototypeESBU
Copy link
Collaborator

Root cause of this is that .foreach() functions can't work asynchronously.

@PrototypeESBU PrototypeESBU linked a pull request May 26, 2024 that will close this issue
@PrototypeESBU PrototypeESBU self-assigned this May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants