Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Make the Composer scripts for fixing things more consistent #1362

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

oliverklee
Copy link
Contributor

  • always use the fix: prefix for all fixing-related Composer scripts
  • add a fix script to conveniently run all fixers
  • add a missing script description

- always use the `fix:` prefix for all fixing-related Composer scripts
- add a `fix` script to conveniently run all fixers
- add a missing script description
@oliverklee oliverklee added this to the 8.0.0 milestone Nov 3, 2024
@oliverklee oliverklee requested a review from JakeQZ November 3, 2024 09:22
@oliverklee oliverklee self-assigned this Nov 3, 2024
@coveralls
Copy link

coveralls commented Nov 3, 2024

Coverage Status

coverage: 97.062%. remained the same
when pulling d1fc8ef on task/fix-commands
into 0de9c22 on main.

Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is a more logical structure.

These scripts aren't used by any GitHub Actions so there are no corresponding changes needed there.

@JakeQZ JakeQZ merged commit 93995da into main Nov 3, 2024
26 checks passed
@JakeQZ JakeQZ deleted the task/fix-commands branch November 3, 2024 19:27
@JakeQZ
Copy link
Contributor

JakeQZ commented Nov 3, 2024

There wasn't previously a missing script description, so I removed that bullet-point from the commit message. (The added description was for the newly added fix script.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants