[FEATURE] Add Rector to our development toolchain #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rename the `fix:php` script to be more specific now that we have two PHP-related fixing scripts. Fixes #890
oliverklee
added
enhancement
dependencies
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JakeQZ
approved these changes
Nov 7, 2024
The newly added PHP file happens to be a config file, so does not need tests added for it. |
How do you override the github-actions bot's request for changes? |
As an admin on this repository (which we both are, as far as I can tell), there is a checkbox "merge anyway" that allows us to merge PRs even if some requirements are not fulfilled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rename the
fix:phpscript to be more specific now that we have two PHP-related fixing scripts.Fixes #890