Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Send Confirmation Email Again" for Registration form #111

Open
michaelgira23 opened this issue Jan 12, 2019 · 3 comments
Open

Add "Send Confirmation Email Again" for Registration form #111

michaelgira23 opened this issue Jan 12, 2019 · 3 comments

Comments

@michaelgira23
Copy link
Member

That way, the user doesn't have to resubmit the form. Would probably require another backend API endpoint.

@sbaumohl
Copy link
Member

sbaumohl commented Dec 5, 2019

instead of another endpoint, could we use idempotency IDs on the backend for registration so that if the same idempotency ID appears, it just sends another email? On the frontend, this wouldn't change anything.

@sbaumohl sbaumohl self-assigned this Dec 5, 2019
@michaelgira23
Copy link
Member Author

I don't know if I understand exactly what you mean? If a user resubmits a registration form under the same username, it will automatically override an unconfirmed user in the database. If they don't receive an email, they should be able to resend the email without filling the form again. This is more of a UX enhancement.

However, you are right that a new confirmation link is generated each register, which breaks old links. We might want to fix that too.

@sbaumohl
Copy link
Member

sbaumohl commented Dec 5, 2019

maybe we would have the resubmit button, this would have the frontend send the same info to the server with an ID. if that ID matches an unconfirmed user (meaning that its the same username, email, etc.), then it doesn't overwrite, it just sends another confirmation email. If I understand this correctly, it wouldn't require another endpoint.

@sbaumohl sbaumohl added this to the School Year 2020-21 milestone Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants