Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Usability of 'send_zk_uop.ts' script #26

Open
hiroism007 opened this issue Oct 23, 2023 · 0 comments
Open

Enhance Usability of 'send_zk_uop.ts' script #26

hiroism007 opened this issue Oct 23, 2023 · 0 comments
Labels
good first issue Good for newcomers zkp

Comments

@hiroism007
Copy link
Member

Describe the feature you would like

This script is designed to create UserOperation for ZKMynaWallet and send it to the bundler set in .env. Although several values are currently set as fixed or hardcoded, there is a need to refactor the script to make it user-friendly for everyone. It is not necessary to perform all updates at once, but here are some suggested areas for improvement:

  • Create a manual for the script, detailing its purpose, functionalities, and how it operates.
  • Refactor the code by modularizing functions and adding comments for better clarity and understanding.
  • Modify the script to load the test RSA keys from .env, with a fallback to the test keys within the script if .env keys are unavailable.
  • Update the script to load the value of userSecret from .env.

Additional context

No response

@hiroism007 hiroism007 added good first issue Good for newcomers zkp labels Oct 23, 2023
sakuyacatcat added a commit to sakuyacatcat/myna-wallet-monorepo that referenced this issue Nov 7, 2023
sakuyacatcat added a commit to sakuyacatcat/myna-wallet-monorepo that referenced this issue Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers zkp
Projects
None yet
Development

No branches or pull requests

1 participant