Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace separator of type check snapshots from '---' to '=====' #903

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

Myriad-Dreamin
Copy link
Owner

@Myriad-Dreamin Myriad-Dreamin commented Nov 26, 2024

The previously used --- separator is exact the yaml's file separator, which might confuse insta to extract content from the snapshot file (in yaml format).

Possibly fix #868

@GaetanLepage could you take a look whether this PR solves the problem?

@GaetanLepage
Copy link

Unfortunately, it still fails with this patch.
Thank you for the proposition nonetheless !

@Myriad-Dreamin Myriad-Dreamin merged commit 6d5c353 into main Nov 26, 2024
13 checks passed
@Myriad-Dreamin Myriad-Dreamin deleted the insta-bad-separator branch November 26, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

analysis::type_check_tests::test and rename::tests::test fail as of 0.12.2
2 participants