decouple transactional test runner from indexer and graphql flavor #20373
+354
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
wlmyng
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
wlmyng
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
wlmyng
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
wlmyng
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
wlmyng
requested review from
amnn,
stefan-mysten,
emmazzz and
suiwombat
as code owners
wlmyng
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
wlmyng
changed the title
| @@ -73,6 +75,12 @@ pub struct SuiInitArgs { | |||
| /// the indexer. | |||
| #[clap(long = "epochs-to-keep")] | |||
| pub epochs_to_keep: Option<u64>, | |||
| /// TODO (wlmyng): doc comment | |||
| #[clap(long = "data-ingestion-path")] | |||
There was a problem hiding this comment.
No need to name the long as the field data_ingestion_path will be data-ingestion-path as an option. I see that the rest of the code is like that, so probably it's better to keep the style the same, but just FYI.
Comment on lines
+1944
to
+1967
| impl Default for AdapterInitConfig { | ||
| fn default() -> Self { | ||
| Self { | ||
| additional_mapping: BTreeMap::new(), | ||
| account_names: BTreeSet::new(), | ||
| protocol_config: ProtocolConfig::get_for_max_version_UNSAFE(), | ||
| is_simulator: false, | ||
| custom_validator_account: false, | ||
| reference_gas_price: None, | ||
| default_gas_price: None, | ||
| flavor: None, | ||
| offchain_config: None, | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
If ProtocolConfig has a Default, then we could just slap a #[derive(Default)] on AdapterInitConfig.
There was a problem hiding this comment.
while that's fair, i think i'll keep it like this just so it's explicitly clear the unsafe bit
wlmyng
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
… the latter is a convenience fn
… may consider making this generic as well..
… simulacrum. creating a rest-api, and hooking into the indexer and graphql, should be deferred to the crate caller. but this is probably not the correct approach, because by adding to SuiInitArgs -> Offchain extensions we still have a dependency on the crates...
…apshot state checking functionality, and a few things like configuring graphql based on what we passed into SuiInitArgs. I think we need to figure out a way to take the reader-specific args from SuiInitArgs and handle them in tests.rs. and maybe we hsould have a readerclient? or at least pass in the db url. or the adapter can return a tempdb for the indexer to write to...
…f init args were being instantiated
… this also means that we can actually use the result of serve_executor, with some arc magic I suppose. Now, the workflow is to start the adapter first to instantiate the simulacrum, extract the offchain_config, start the indexer and graphql services, and pass in some sort of offchain reader for the adapter. Make sure to clean up resources by reclaiming the arc
wlmyng
force-pushed
the
test-runner-configurable-adapter
branch
from
6a04673
to
c9e0869
Compare
wlmyng
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With mvr and alt coming up, we want our transactional test runner to be more agnostic to the off chain indexing flavor. This PR attempts to address it by largely limiting the adapter to instantiating the simulacrum or executor with what is needed to bootstrap the network, and then defer to the test caller. Test caller implements a trait so the adapter knows how to inspect off chain state.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.