Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.3 user root persistence migration can indadvertantly delete user roots #240

Open
mudinthewater opened this issue Dec 3, 2024 · 0 comments
Labels
defect every defect must have an accompanying criticality, or `crit-`

Comments

@mudinthewater
Copy link
Contributor

mudinthewater commented Dec 3, 2024

Describe the defect

Despite receiving an http:200 on the /user//root object for 6 users, 5.3 initiated new object PUT requests overwriting the user persistence storage.

Expected behavior

Not do that

Steps To Reproduce
Is network related! This can be reproduced or simulated by loading OMM, then disconnecting from your network and interacting with user folders. OMM will request a new root be created if you interact with the user folder.

This can cause issues with spotty network connections, where one connection may fail but another succeed - i.e. if download was briefly interrupted but upload wasn't, OMM could wipe the entire user folder list, which is what we've seen in logs.

Additional context

crit4 - Now that we know the cause I've coded FastMIO to 409 conflict on these create requests if they already exist. This should provide plenty of time for the bug to be addressed in the next release cycle. Should verify that MCWS also 409 conflicts, otherwise this could be a 2.

@mudinthewater mudinthewater added the defect every defect must have an accompanying criticality, or `crit-` label Dec 3, 2024
@davetsay davetsay removed the defect every defect must have an accompanying criticality, or `crit-` label Feb 5, 2025
@davetsay davetsay added this to the MC 2512 Engineering Release 2 milestone Feb 6, 2025
@davetsay davetsay added the defect every defect must have an accompanying criticality, or `crit-` label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect every defect must have an accompanying criticality, or `crit-`
Projects
None yet
Development

No branches or pull requests

2 participants