Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to click on the affected URLs of a pattern and see which URLs have been affected #1009

Open
code-geek opened this issue Sep 6, 2024 · 1 comment · May be fixed by #1038
Open

Ability to click on the affected URLs of a pattern and see which URLs have been affected #1009

code-geek opened this issue Sep 6, 2024 · 1 comment · May be fixed by #1038
Assignees

Comments

@code-geek
Copy link
Contributor

Description

Right now the affected URLs number is not clickable, and there is no way to tell which N URLs were affected by a particular pattern. This feature adds an ability to click into the number and actually see the URLs.

Implementation Considerations

  • This will require a brand new page which should have the same styling as the rest of the website
  • A way to do this is to filter the candidate URLs list itself for these affected URLs so that all functionality is preserved.

Deliverable

  • Ability to drill into affected URLs

Dependencies

No response

@CarsonDavis
Copy link
Collaborator

The code attached to this card implements the Affected Url functionality, where you can see which urls are being affected by a particular pattern. We need to refactor this to work with the new Delta patterns, potentially pointing towards Pattern.delta_urls and Pattern.curated_urls. Since these fields are inherited by all the patterns, we can probably make our functionality extent to all pattern types, not just excludes and includes.

Looking through the code, it seems like there are a lot of individual new views. However I'm thinking that we might be able to make a single viewfunction that takes patterns as an argument or something along those lines, and generates the view.

We will work on this in PI 25.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants