Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code scanning alert - Inclusion of functionality from an untrusted source #1240

Open
CarsonDavis opened this issue Feb 25, 2025 · 0 comments · May be fixed by #1245
Open

Fix code scanning alert - Inclusion of functionality from an untrusted source #1240

CarsonDavis opened this issue Feb 25, 2025 · 0 comments · May be fixed by #1245
Assignees
@saifrk

Comments

@CarsonDavis
Copy link
Collaborator

Overview

There are several alerts being thrown for js files that are imported but unverified. For example: https://github.com/NASA-IMPACT/COSMOS/security/code-scanning/41.

Deliverable

Look through all the examples raised in https://github.com/NASA-IMPACT/COSMOS/pull/1213/checks?check_run_id=37794953224, and fix each one of them with the following pattern:

<html>
    <head>
        <title>jQuery demo</title>
        <script src="https://code.jquery.com/jquery-3.6.0.slim.min.js" integrity="sha256-u7e5khyithlIdTpu22PHhENmPcRdFiHRjhAuHcs05RI=" crossorigin="anonymous"></script>
    </head>
    <body>
        ...
    </body>
</html>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saifrk saifrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement HTTPS and add SRI to external resources to fix CodeQL alert NASA-IMPACT/COSMOS
2 participants
@CarsonDavis @saifrk