Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all cache configuration in CDK #108

Closed
3 tasks
drewbo opened this issue Jan 23, 2021 · 0 comments · Fixed by #109
Closed
3 tasks

Include all cache configuration in CDK #108

drewbo opened this issue Jan 23, 2021 · 0 comments · Fixed by #109

Comments

@drewbo
Copy link
Contributor

drewbo commented Jan 23, 2021

Currently, one portion of the cache configuration (inbound security group rules) is left out of the CDK setup because I was initially worried about circular references. However I think I was unclear about some CDK functionality because it should be possible to include.

  • create a security group to be used by the lambda (only needs allowAllOutbound); we need the reference to the lambda security group later and currently there is no method to get this from an automatically generated security group on lambda in VPC creation.
  • call the sg.addIngressRule method on the cache security group to add ingress from the lambda function's security group created above

Additional related improvements:

  • the two policies that are added to the lambda role have unhelpful names (iam_policy_statement and vpc_access_policy_statement); probably worth coming up with something better for future readers

cc: @leothomas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant