Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/57 cache #58

Merged
merged 6 commits into from
Aug 25, 2020
Merged

Feature/57 cache #58

merged 6 commits into from
Aug 25, 2020

Conversation

drewbo
Copy link
Contributor

@drewbo drewbo commented Aug 25, 2020

Probably close #57

can't really test properly until it's deployed

@vincentsarago vincentsarago self-requested a review August 25, 2020 16:47
Copy link
Contributor

@vincentsarago vincentsarago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one change!

@vincentsarago vincentsarago self-requested a review August 25, 2020 16:48
Copy link
Contributor

@leothomas leothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of interest - where does the cache invalidation time get set?

covid_api/db/memcache.py Outdated Show resolved Hide resolved
@drewbo
Copy link
Contributor Author

drewbo commented Aug 25, 2020

Out of interest - where does the cache invalidation time get set?

https://github.com/NASA-IMPACT/covid-api/pull/58/files#diff-3c917929460c66df9179c64dee69da41R69

@drewbo drewbo merged commit 5ca3b57 into develop Aug 25, 2020
@drewbo drewbo deleted the feature/57-cache branch August 25, 2020 18:01
@leothomas
Copy link
Contributor

leothomas commented Aug 25, 2020

Oh nice, I feel like I could have figured that out on my own :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce time required to return /datasets response
3 participants