Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Lambda package generation in CDK #98

Closed
leothomas opened this issue Dec 23, 2020 · 0 comments · Fixed by #99
Closed

Refactor Lambda package generation in CDK #98

leothomas opened this issue Dec 23, 2020 · 0 comments · Fixed by #99
Assignees
@leothomas
Labels
enhancement New feature or request

Comments

@leothomas
Copy link
Contributor

The current method of generating the lambda deployment package, using asset is deprecated.

The preferred method, from_asset has the ability to execute docker commands to create the package (removing the need to create the package here and I'm always for simplifying code.

This is mostly a style issue, low priority and low impact (no immediate danger).
@leothomas leothomas added the enhancement New feature or request label Dec 23, 2020
@leothomas leothomas self-assigned this Dec 23, 2020
@leothomas leothomas mentioned this issue Dec 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leothomas leothomas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor lambda package generation in CDK NASA-IMPACT/covid-api
1 participant
@leothomas