Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setProjection for scrollytelling not working #1007

Closed
1 task
hanbyul-here opened this issue Jun 18, 2024 · 0 comments
Closed
1 task

setProjection for scrollytelling not working #1007

hanbyul-here opened this issue Jun 18, 2024 · 0 comments
Assignees
@hanbyul-here

Comments

@hanbyul-here
Copy link
Collaborator

Context

While migrating Scrollytelling component to the new map component, a bug that setProjection not working was introduced.
Refer to the original PR and the comment:
https://github.com/NASA-IMPACT/veda-ui/pull/992/files#diff-af7791d70ec6eacf00bc029b1e7b44b287a9d2c6cc737a56acd4d1b20cda8f1cR306-R307

Acceptance Criteria

  • Given when Scrollytelling block can set the projection with a paassed projectionId value .

Related Tickets

#967
@hanbyul-here hanbyul-here mentioned this issue Jun 18, 2024
Closed
@hanbyul-here hanbyul-here mentioned this issue Jun 24, 2024
Merged
hanbyul-here added a commit that referenced this issue Jun 25, 2024
@hanbyul-here
Fix scrollytelling projection problem (#1011)
6bebe58 
**Related Ticket:** #1007 

### Description of Changes
- Fix projection change bug introduced by
#992

### Notes & Questions About Changes


### Validation / Testing
Check projection change on Sandbox Scrollytelling page:
https://deploy-preview-1011--veda-ui.netlify.app/sandbox/mdx-scrolly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hanbyul-here hanbyul-here

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hanbyul-here