fix: Menu Drop down #1342
Open
fix: Menu Drop down #1342
+29
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
snmln
force-pushed
the
1296-page-header-close-dropdown-when-clicking-outside
branch
from
b1c9d34 to
5acc803
Compare
AliceR
reviewed
Dec 19, 2024
| @@ -0,0 +1,15 @@ | |||
| import { useEffect, useRef } from 'react'; | |||
There was a problem hiding this comment.
Not very important, but maybe we can move both use-fix-hooks in the same directory? app/scripts/components/common/page-header/use-mobile-menu-fix.ts is the one i implemented for the resize bug. I don't care which directory, but I like them together 🙂
There was a problem hiding this comment.
@AliceR I think the new hook is generic enough to be useful in other places not limited to this component, so it might make sense to keep it in the general utils directory?
AliceR
reviewed
Dec 19, 2024
dzole0311
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close the new USWDS page header dropdown when clicking outside of it
#1296
Validation / Testing
Open one of the two drop down options, click on another link on the page. When the browser navigates to the new page that original dropdown menu should be closed.