Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart component improvement based on feedback from beta release #141

Closed
hanbyul-here opened this issue May 24, 2022 · 4 comments
Closed
Assignees

Comments

@hanbyul-here
Copy link
Collaborator

play with /statistics and figure out what needs to be tweaked/improved regarding Chart component

@hanbyul-here
Copy link
Collaborator Author

hanbyul-here commented Jun 16, 2022

  • make yaxis label configurable
  • offer 'alt text'
  • option for colors
  • not number y value (ex.%)
  • highlight one line
  • check why the data gets shifted in %m/%Y format

@hanbyul-here hanbyul-here changed the title [analysis] chart component + stac /statistics endpoint [analysis] chart component improvement + stac /statistics endpoint Jun 16, 2022
@hanbyul-here hanbyul-here self-assigned this Jun 22, 2022
@anayeaye
Copy link

This could be related: NASA-IMPACT/veda-backend#70. It's an easy change if you need mosaic statistics.

@hanbyul-here
Copy link
Collaborator Author

hanbyul-here commented Jun 22, 2022

I wanted to figure out why the data gets shifted, and at least confirmed that it was a bug introduced to the library that we are depending on now. (I filed an issue: plouc/nivo#2054)
I could make the error go away by changing the version of the library, but it is a serious setback (the current one is 0.79, and I had to go down to 0.56) so I am hoping the library maintainer can fix it soon. (or maybe I can contribute 🤔 )

This is how chart looks like with v0.56 (maybe not too bad with some styiling?)
Screen Shot 2022-06-22 at 5 38 01 PM

update: It was timezone problem and could fix with an additional attribute useUTC, Thanks @danielfdsilva for looking into the problem!

@hanbyul-here hanbyul-here changed the title [analysis] chart component improvement + stac /statistics endpoint chart component improvement based on feedback from beta release Jul 7, 2022
@hanbyul-here
Copy link
Collaborator Author

I edited the title of this ticket to narrow down the scope of it. We will make a new one if we need further improvements of chart component for analysis page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants