Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back route redirection from /discoveries to /stories #729

Closed
1 task
j08lue opened this issue Nov 2, 2023 · 1 comment · Fixed by #731
Closed
1 task

Bring back route redirection from /discoveries to /stories #729

j08lue opened this issue Nov 2, 2023 · 1 comment · Fixed by #731

Comments

@j08lue
Copy link
Contributor

j08lue commented Nov 2, 2023

There are apparently still links to old "Discoveries" of the VEDA NASA/EIS instance out there, which are broken since we renamed /discoveries to /stories.

Like https://www.earthdata.nasa.gov/dashboard/discoveries/wq-models

Did we have a redirect from these legacy links in place at some point? If so, perhaps we removed it while fixing #682?

If it is not much trouble, we should bring this redirect back.

Acceptance criteria

  • Assessed the effort / consequences of (re-)introducing redirect from discoveries to stories and implemented, if sensible.
@hanbyul-here
Copy link
Collaborator

There is a change that reintroduces the discovery redirection. At least, based on the assessment of my local profilers, it seems to be working ok. I would rather deprecate this, especially if we are launching EIC page (where this page is linked.)

https://github.com/NASA-IMPACT/veda-ui/tree/fix/back-redirection

@hanbyul-here hanbyul-here mentioned this issue Nov 2, 2023
Merged
hanbyul-here added a commit that referenced this issue Nov 6, 2023
@hanbyul-here
Add discoveries redirection back (#731)
6105ce0 
This PR reintroduces the redirection of the discoveries -> stories. 

Close #729

Since we could not figure out the root cause of the app crash other than
there was a problem with a combination of redirecting and shadow scroll,
I generally want to be careful about this change. I tested it a bit and
it seems working as expected without overheads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add discoveries redirection back NASA-IMPACT/veda-ui
2 participants
@j08lue @hanbyul-here