Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HT, HU,... to get_grid #14

Open
matt-long opened this issue Jun 5, 2019 · 2 comments · May be fixed by #54
Open

Add HT, HU,... to get_grid #14

matt-long opened this issue Jun 5, 2019 · 2 comments · May be fixed by #54
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@matt-long
Copy link
Collaborator

HT = z_w(KMT)
HU = z_w(KMU)
KMU[i, j] = min(KMT[i, j] , KMT[i−1,j] , KMT[i, j−1], KMT[i−1,j−1])

@matt-long matt-long added the help wanted Extra attention is needed label Jun 5, 2019
@klindsay28
Copy link
Collaborator

Note that the above equations will generate an IndexError where KMT==km,
and are incorrect if partial_bottom_cells=.true..
To handle pbc grids, I suggest adding bottom_cell_file to pop_grid_definitions.yaml.

@andersy005 andersy005 added the enhancement New feature or request label Jul 31, 2019
@bradyrx bradyrx linked a pull request May 29, 2020 that will close this issue
@dcherian
Copy link
Contributor

From @klindsay28 in #44 (comment)

The following (untested) code replaces nested j,i loops with a single k loop.
It seems like it would be more cache friendly.

for k in range(VOL.shape[0]):
    VOL[k, :, :] = np.where(k < KMT, VOL[k, :, :], 0.0)

We'll need this to specify VOL as an xgcm metric.

@dcherian dcherian mentioned this issue Mar 23, 2021
2 tasks
@andersy005 andersy005 added this to Xdev Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

4 participants