Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMT returned from get_grid does not include overflow pop-downs #38

Open
matt-long opened this issue Mar 6, 2020 · 2 comments
Open

KMT returned from get_grid does not include overflow pop-downs #38

matt-long opened this issue Mar 6, 2020 · 2 comments

Comments

@matt-long
Copy link
Collaborator

matt-long commented Mar 6, 2020

Here is diff between pop_tools.get_grid('gx1v7').KMT - ds_ref.KMT, where ds_ref was read from model output:
image

KMT is depressed by 1 at the overflow locations.

Not clear how to proceed here...

@mnlevy1981
Copy link
Collaborator

Could you add an include_overflow option to get_grid() and then mimic POP when include_overflow = True? I only sort of understand the overflow code, but if the overflow locations are hard-coded in the POP codebase then they'd need to be hard-coded into get_grid() as well; if instead POP sets it up based on a configuration file somewhere, pop-tools would need to access that same file.

Implementation detail, but I would have the default value of include_overflow be None, and then do something like

if include_overflow is None:
    include_overflow = grid_name.startswith('gx1')

(because we only use overflows in the 1 degree grid, right?)

@matt-long
Copy link
Collaborator Author

The overflow parameterization reads an input file that specifies the KMT "pops." We could read that file and do what you suggest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants