Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pop_tools.to_xgcm_grid_dataset does not detect whether the attributes necessary to relabel grid are present #50

Open
ALDepp opened this issue May 15, 2020 · 1 comment

Comments

@ALDepp
Copy link
Contributor

ALDepp commented May 15, 2020

I tried to convert a datset with nlat, nlon to the xgcm nlat_t, nlon_t, nlat_u, nlon_u grid using pop_tools.to_xgcm_grid_dataset.

Nothing happened, because I had performed a reduction on the data with xarray before, which removed the attributes, but I also didn't get an error.

It would be nice if pop_tools.to_xgcm_grid_dataset raised an error if there are no attributes, and warning for the variables without attributes in case there are some with and some without.

@mnlevy1981
Copy link
Collaborator

@ALDepp -- can you provide a brief example and point out where you would expect an error? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants