Add Logger flushing and launch data #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshil21
reviewed
Feb 23, 2025
| @@ -197,6 +197,7 @@ class DisplayEndingType(StrEnum): | |||
| """The path of the folder to hold the log files in.""" | |||
| TEST_LOGS_PATH = Path("test_logs") | |||
| """The path of the folder to hold the test log files in.""" | |||
| NUMBER_OF_LINES_TO_BEFORE_LOGGING = 20 | |||
There was a problem hiding this comment.
i'm adding this in my PR which fixes the mock, so can you remove?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be tested but I cant run mocks on my laptop anymore
Also if you want me to change the launch data name I can but idrk what to change it to
Closes #160