diff --git a/article-api/src/main/scala/no/ndla/articleapi/ArticleApiProperties.scala b/article-api/src/main/scala/no/ndla/articleapi/ArticleApiProperties.scala index f3d74674cf..c88264307f 100644 --- a/article-api/src/main/scala/no/ndla/articleapi/ArticleApiProperties.scala +++ b/article-api/src/main/scala/no/ndla/articleapi/ArticleApiProperties.scala @@ -103,7 +103,7 @@ class ArticleApiProperties extends BaseProps { ResourceType.H5P.toString -> H5PAddress ) - def InlineHtmlTags: Set[String] = Set("code", "em", "span", "strong", "sub", "sup") + def InlineHtmlTags: Set[String] = Set("code", "em", "span", "sub", "sup") def IntroductionHtmlTags: Set[String] = InlineHtmlTags ++ Set("br", "p") private def H5PAddress: String = propOrElse( diff --git a/article-api/src/main/scala/no/ndla/articleapi/validation/ContentValidator.scala b/article-api/src/main/scala/no/ndla/articleapi/validation/ContentValidator.scala index 22ee37e371..4b556f08d8 100644 --- a/article-api/src/main/scala/no/ndla/articleapi/validation/ContentValidator.scala +++ b/article-api/src/main/scala/no/ndla/articleapi/validation/ContentValidator.scala @@ -13,21 +13,21 @@ import no.ndla.articleapi.repository.ArticleRepository import no.ndla.common.errors.{ValidationException, ValidationMessage} import no.ndla.common.model.NDLADate import no.ndla.common.model.domain.article.{Article, Copyright} -import no.ndla.common.model.domain._ +import no.ndla.common.model.domain.* import no.ndla.language.model.{Iso639, LanguageField} import no.ndla.mapping.License.getLicense import no.ndla.validation.HtmlTagRules.{allLegalTags, stringToJsoupDocument} import no.ndla.validation.SlugValidator.validateSlug import no.ndla.validation.TextValidator -import scala.jdk.CollectionConverters._ +import scala.jdk.CollectionConverters.* import scala.util.{Failure, Success, Try} trait ContentValidator { - this: ArticleRepository with Props => + this: ArticleRepository & Props => val contentValidator: ContentValidator - class ContentValidator() { + class ContentValidator { private val inlineHtmlTags = props.InlineHtmlTags private val introductionHtmlTags = props.IntroductionHtmlTags @@ -73,7 +73,7 @@ trait ContentValidator { } } - private def validateNonEmpty(field: String, values: Seq[LanguageField[_]]): Option[ValidationMessage] = { + private def validateNonEmpty(field: String, values: Seq[LanguageField[?]]): Option[ValidationMessage] = { if (values.isEmpty || values.forall(_.isEmpty)) { Some(ValidationMessage(field, "Field must contain at least one entry")) } else diff --git a/article-api/src/test/scala/no/ndla/articleapi/db/migration/V54__RemoveStrongFromTitleTest.scala b/article-api/src/test/scala/no/ndla/articleapi/db/migration/V54__RemoveStrongFromTitleTest.scala index dd0b57599e..03a446c702 100644 --- a/article-api/src/test/scala/no/ndla/articleapi/db/migration/V54__RemoveStrongFromTitleTest.scala +++ b/article-api/src/test/scala/no/ndla/articleapi/db/migration/V54__RemoveStrongFromTitleTest.scala @@ -30,7 +30,8 @@ class V54__RemoveStrongFromTitleTest extends UnitSuite with TestEnvironment { } test("That strong are removed from title in article") { - val oldContent = ArticleContent("

This is a title

Some text

", language = "nb") + val oldContent = + ArticleContent("

This is a title

Some text

", language = "nb") val expectedContent = ArticleContent("

This is a title

Some text

", language = "nb") val migration = new V54__RemoveStrongFromTitle diff --git a/draft-api/src/main/scala/no/ndla/draftapi/DraftApiProperties.scala b/draft-api/src/main/scala/no/ndla/draftapi/DraftApiProperties.scala index 5e0ec3ac57..aea5127141 100644 --- a/draft-api/src/main/scala/no/ndla/draftapi/DraftApiProperties.scala +++ b/draft-api/src/main/scala/no/ndla/draftapi/DraftApiProperties.scala @@ -57,7 +57,7 @@ class DraftApiProperties extends BaseProps with StrictLogging { "image-api" -> s"http://$ImageApiHost/intern" ) - def InlineHtmlTags: Set[String] = Set("code", "em", "span", "strong", "sub", "sup") + def InlineHtmlTags: Set[String] = Set("code", "em", "span", "sub", "sup") def IntroductionHtmlTags: Set[String] = InlineHtmlTags ++ Set("br", "p") private def BrightcoveAccountId: String = prop("NDLA_BRIGHTCOVE_ACCOUNT_ID") diff --git a/draft-api/src/main/scala/no/ndla/draftapi/validation/ContentValidator.scala b/draft-api/src/main/scala/no/ndla/draftapi/validation/ContentValidator.scala index d0b7d48f57..60c5374b6a 100644 --- a/draft-api/src/main/scala/no/ndla/draftapi/validation/ContentValidator.scala +++ b/draft-api/src/main/scala/no/ndla/draftapi/validation/ContentValidator.scala @@ -9,8 +9,8 @@ package no.ndla.draftapi.validation import no.ndla.common.errors.{ValidationException, ValidationMessage} import no.ndla.common.model.NDLADate -import no.ndla.common.model.domain._ -import no.ndla.common.model.domain.draft._ +import no.ndla.common.model.domain.* +import no.ndla.common.model.domain.draft.* import no.ndla.draftapi.Props import no.ndla.draftapi.integration.ArticleApiClient import no.ndla.draftapi.model.api.{ContentId, NotFoundException, UpdatedArticle} @@ -21,18 +21,18 @@ import no.ndla.mapping.License.getLicense import no.ndla.network.tapir.auth.TokenUser import no.ndla.validation.HtmlTagRules.{allLegalTags, stringToJsoupDocument} import no.ndla.validation.SlugValidator.validateSlug -import no.ndla.validation._ +import no.ndla.validation.* import scalikejdbc.ReadOnlyAutoSession -import scala.jdk.CollectionConverters._ +import scala.jdk.CollectionConverters.* import scala.util.{Failure, Success, Try} trait ContentValidator { - this: DraftRepository with ConverterService with ArticleApiClient with Props => + this: DraftRepository & ConverterService & ArticleApiClient & Props => val contentValidator: ContentValidator val importValidator: ContentValidator - class ContentValidator() { + class ContentValidator { import props.{BrightcoveVideoScriptUrl, H5PResizerScriptUrl, NRKVideoScriptUrl} private val inlineHtmlTags = props.InlineHtmlTags private val introductionHtmlTags = props.IntroductionHtmlTags