New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generalize cholesky_serial code #29

Open

hcq9102 wants to merge 2 commits into NERSC:main from hcq9102:cleancode

Contributor

hcq9102 commented Dec 8, 2023 •

edited

Loading

This PR for clean up cholesky_serial code:

simplify the code, improve readability
read input file from command line by adding --input_file="inputFilePath"
data type consistency
remove unnecessary args and functions


          generalize cholesky_serial code

Contributor Author

hcq9102 commented Dec 8, 2023 •

edited

Loading

Hi @weilewei @mhaseeb123, please review this PR if possible.

Do you think I should make a new PR just for cleaning up cholesky_stdpar, or should I wait until this one gets merged?


          correct name

e50107f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet