Fixed remove_character() leaving empty indexes #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a monster kills a character, the character is removed only after update_characters(), so the characters dictionary can end up having indexes that have empty character lists, like this:
{40: []}
.This can cause the condition
not self.world.characters
in game.done() and a similar condition in our group's terminal state checks to return False when there are no characters instead of True.I added a couple lines to world.remove_character() to check if the removed character leaves its list empty, and if so deletes the index. Tested by printing the result of
not wrld.characters
in a sensed world where the monster kills the player in Variant 2 of Scenario 2, and it seems to work now.