From 34b8945960af31f1d45b6e69d3df6002451fc4e7 Mon Sep 17 00:00:00 2001 From: Kris Szlapa Date: Tue, 8 Oct 2024 11:27:08 +0000 Subject: [PATCH] Correct the stack name --- .github/scripts/delete_stacks.sh | 6 +++--- Makefile | 2 +- README.md | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/scripts/delete_stacks.sh b/.github/scripts/delete_stacks.sh index a7a5918..f8efa25 100755 --- a/.github/scripts/delete_stacks.sh +++ b/.github/scripts/delete_stacks.sh @@ -6,13 +6,13 @@ REPO_NAME=eps-aws-dashboards # this should be a regex used in jq command that parses the output from aws cloudformation list-stacks and just captures stacks we are interested in -CAPTURE_REGEX="^cpt-ui-(sandbox-)?pr-(\\d+)$" +CAPTURE_REGEX="^dashboards-(sandbox-)?pr-(\\d+)$" # this should be a regex that is used to get the pull request id from the cloud formation stack name # this is used in a replace command to replace the stack name so what is left is just the pull request id -PULL_REQUEST_STACK_REGEX=cpt-ui-pr- +PULL_REQUEST_STACK_REGEX=dashboards-pr- -CNAME_QUERY=cpt-ui-pr +CNAME_QUERY=dashboards-pr # this should be customised to delete cloudformation stacks and proxygen deployments if they are used main() { diff --git a/Makefile b/Makefile index 9b99f7b..21966d3 100644 --- a/Makefile +++ b/Makefile @@ -82,7 +82,7 @@ cdk-deploy: guard-stack_name cdk-synth: npx cdk synth \ --app "npx ts-node --prefer-ts-exts packages/cdk/bin/DashboardsApp.ts" \ - --context stackName=cpt-ui \ + --context stackName=dashboards \ --context VERSION_NUMBER=undefined \ --context COMMIT_ID=undefined \ --context epsDomain=$$epsDomain \ diff --git a/README.md b/README.md index ddb2e63..edb8f1e 100644 --- a/README.md +++ b/README.md @@ -188,7 +188,7 @@ Workflows are in the `.github/workflows` folder: - `dependabot_auto_approve_and_merge.yml` Workflow to auto merge dependabot updates. - `pr_title_check.yml` This workflow checks the pull request title has the correct format. - `pr-link.yml` This workflow template links Pull Requests to Jira tickets and runs when a pull request is opened. -- `pull_request.yml` Called when pull request is opened or updated. Calls package_code and release_code to build and deploy the code. Deploys to dev AWS account. The main stack deployed adopts the naming convention cpt-ui-pr- +- `pull_request.yml` Called when pull request is opened or updated. Calls package_code and release_code to build and deploy the code. Deploys to dev AWS account. The main stack deployed adopts the naming convention dashboards-pr- - `quality_checks.yml` Runs check-licenses, lint, test and SonarCloud scan against the repo. Called from pull_request.yml and release.yml - `release.yml` Creates a new release tag and deploys to all environments - `cdk_package_code.yml` Packages code into a docker image and uploads to a github artifact for later deployment.