Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for other attribute sources than $_SERVER #2

Open
osnard opened this issue Jan 30, 2019 · 4 comments
Open

Allow for other attribute sources than $_SERVER #2

osnard opened this issue Jan 30, 2019 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@osnard
Copy link

osnard commented Jan 30, 2019

Depending on the webserver configuration the Shibboleth attributes may not be available in $_SERVER, but for example in the return value of a getallheaders() call. I propose to encapsulate the attribute-extraction logic into configurable "provider" classes (e.g. $wgShibboleth_UserInfoProvider = "headers" or $wgShibboleth_UserInfoProvider = "server-super-global").

@northway
Copy link
Member

You're welcome to create pull request. In the near future, I won't be able to work on this.

@northway northway added help wanted Extra attention is needed enhancement New feature or request good first issue Good for newcomers labels Feb 28, 2019
@osnard
Copy link
Author

osnard commented Mar 1, 2019

I have already started with the implementation but will probably wait until the repo has been moved to WMF gerrit.

@Shugabuga
Copy link

Any updates on this?

@northway
Copy link
Member

I'll take a look at this on January.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants