Contributions #7
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frafra
reviewed
Oct 1, 2024
| @@ -36,6 +37,38 @@ def extract_images_from_video(video_path, output_folder): | |||
|
|
|||
| cap.release() | |||
|
|
|||
| # The following function is my attempt to substitute the function "extract_images_from_video_ffmpeg to avoid using ffmpeg" | |||
| def extract_images_from_video_av(video_path, output_folder): | |||
There was a problem hiding this comment.
Just change the existing function instead of adding a new one, so that it is easy to compare the differences.
|
I flagged this PR as draft since it is a work in progress (merging the code would not fix the related issue, since it just adds a new function that is not being used for now). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6