-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement FromStr for zonemd Scheme and Algorithm #444
base: main
Are you sure you want to change the base?
Conversation
…e consistent with how other IANA parameters are codified in domain, and in so doing gain string and mnemonic conversion functions. This is a breaking change because it renames types, moves types within the module tree, and removes support for named variants for reserved and private use ranges for ZONEMD parameters (as we don't do that for other IANA parameters in domain).
After discussing internally I have reworked this to implement the ZONEMD IANA parameters using the IANA macros as we do for other IANA types and I have labelled this as a breaking change. By using the macros we get a This does however mean that types are renamed, moved in the module tree, and the "reserved", "unassigned" and "private" enum variants are gone (as we don't do that for other IANA parameters) and the |
Noting it down, to not forget it: This (and other types in future PRs) should potentially change to use |
While writing the dnst signzone zonemd argument parsing, I noticed that
zonemd::Scheme
andzonemd::Algorithm
implement neitherFromStr
nor afrom_mnemonic
function (as with the enums created with the iana int_enum macro).I was unsure which one should be used, but settled on
FromStr
with both number and mnemonic, as it allows an easy use ofstr::parse
.