-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report zonefile parsing & signing progress to the caller. #448
Draft
ximon18
wants to merge
17
commits into
byo-signing-sorter-impl
Choose a base branch
from
report-signing-progress
base: byo-signing-sorter-impl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximon18
changed the title
Report zonefile parsing progress to the caller.
Report zonefile parsing & signing progress to the caller.
Nov 25, 2024
ximon18
force-pushed
the
report-signing-progress
branch
from
December 5, 2024 11:57
99e0d40
to
2a8816f
Compare
… output format. (#463)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows callers to report progress, which is especially useful on very large zone files.
For example usage see NLnetLabs/dnst#35.
I'm not very happy with the
inplace::Zonefile
progress support, but due to the replacement of self via the Bytessplit()
operation, reset of thestart
variable and the iterator being mutably consumed by the caller, using a new position tracking variable and returning it viaEntry
seemed like one easy way of getting the progress information out to the iterating caller code.Perhaps something like
Iterator::enumerate()
could be used instead to return the progress offset to the iteration loop?If we keep the extra var returned with
Entry
it should probably be made into named struct fields instead of anonymous tuple fields, to be more self-evident what theusize
value is. Also, the extra tuple field infects all call sites which is annoying as most don't care about it.Note: This PR lacks progress notification for NSEC hashing, that should also be added.
Thoughts:
Option
.