-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a new base
module
#469
Draft
bal-e
wants to merge
17
commits into
main
Choose a base branch
from
rebase
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a
new_base
module as a potential candidate for replacingbase
. While it has a similar structure (although much is left to be filled out), it has three distinguishing features:It builds the foundation for a
derive
-based interface for easily and efficiently parsing (and possibly building) DNS messages.It introduces
RevName
, a more efficient type for domain names (where labels are stored in reverse order).It relies on the
zerocopy
crate to offload basic byte parsing, and to represent big-endian integers where necessary. This saves a fair amount of parsing code.There's a lot more work to be done. Procedural macros for deriving the various parsing traits need to be implemented. Basic record types (e.g.
A
) need to be defined. The OPT record is a special case that requires more attention. Common parsing targets (e.g. a standard IN-class query, and a fallback deconstructed message type) need to be defined. Parts of the existing codebase need to be adjusted to usenew_base
, to demonstrate its usefulness.