Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use imdbid to find movie info instead of movieinfo_id #1462

Closed
ghost opened this issue Nov 16, 2023 · 2 comments
Closed

Use imdbid to find movie info instead of movieinfo_id #1462

ghost opened this issue Nov 16, 2023 · 2 comments
Labels
good first issue Help wanted stale triage

Comments

@ghost
Copy link

ghost commented Nov 16, 2023 •
edited by ghost
Loading

Releases table holds both imdbid and movieinfo_id. Some parts of NNTmux use movieinfo_id and some use imdbid.

I suggest only imdbid is used.

movieinfo_id for example is used for joins in apiSearch() and moviesSearch() in Releases class.

imdbid could even become the primary key I guess.
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Dec 16, 2023
@github-actions GitHub Actions
Copy link

This issue was closed because it has been inactive for 14 days since being marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Help wanted stale triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants