Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPRECATED Implicit conversion from float #1538

Closed
ghost opened this issue Mar 28, 2024 · 0 comments
Closed

DEPRECATED Implicit conversion from float #1538

ghost opened this issue Mar 28, 2024 · 0 comments
Labels
good first issue Help wanted triage

Comments

@ghost
Copy link

ghost commented Mar 28, 2024 •
edited by ghost
Loading 

DEPRECATED  Implicit conversion from float 35.56666666666667 to int loses precision in app/Extensions/helper/helpers.php on line 259.

Called here:

newznab-tmux/Blacklight/ReleaseExtra.php

Line 244 in a7b7295

'videoduration' => is_numeric($videoDuration) ? realDuration($videoDuration) : $videoDuration,

round() returns a double and not an int but the issue seems to be $time/60%60. Changing it to this seems to work: (int) ($time/60) % 60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Help wanted triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants