Update IS_IN_UNGRID to handle if grid lon defintions are mismatched #1325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Update IS_IN_UNGRID to handle if grid lon defintions are mismatched
Description
This PR adds a modified longitude point for the point that you are trying to find in a triangle element. If for example this point is -180 but the grid is defined from 0 to 360 this will address this mismatch and the point will be found in an element.
If there are regtests where the requested point output does not match the grid definition (ufs1.1) then there will be answer changes. This followed the work of the "fix periodicity" routine.
Issue(s) addressed
Fixes #1273
Commit Message
Update IS_IN_UNGRID to handle if grid lon defintions are mismatched
Check list
Testing
We expect that unstructured grid regtests with points defined outside of it's domain definition, such as ufs1.1 will have answer changes.
Not originally expected non-b4b:
Looking into this test case closer, it looks like we're actually finding more points for the interpolation. This test might actually need further investigation (unrelated to this PR) as the interpolated output doesn't seem quite right. However it's the same before and after this PR, but the weights are slightly different.
The ufs1.1 tests now have more output points - indicating this fix is working.