Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gdas.cd #2978

Merged
merged 23 commits into from
Oct 26, 2024
Merged

Update gdas.cd #2978

merged 23 commits into from
Oct 26, 2024

Conversation

guillaumevernieres
Copy link
Contributor

@guillaumevernieres guillaumevernieres commented Oct 3, 2024 •
edited by RussTreadon-NOAA
Loading

Description

Updates to the gdas.cd #.
@RussTreadon-NOAA will submit a PR in the GDASApp, we'll update the gdas.cd # in this branch after the GDASApp PR is merged.
In the mean time, could somebody review the few simple code changes that are needed to run with the new #?

  • Depends on GDASApp PR #1310
  • Depends on g-w issue #3012

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES

How has this been tested?

Run subset of g-w CI on Hera, Hercules, Orion, and WCOSS2 (Cactus)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • This change is covered by an existing CI test or a new one has been added

CoryMartin-NOAA
CoryMartin-NOAA previously approved these changes Oct 3, 2024
View reviewed changes
@RussTreadon-NOAA RussTreadon-NOAA mentioned this pull request Oct 4, 2024
Merged
aerorahul
aerorahul previously approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@RussTreadon-NOAA
Copy link
Contributor

@guillaumevernieres , the hash for sorc/gdas.cd can be updated. GDASApp PR #1310 was merged into develop at 9d95c9d.

@guillaumevernieres guillaumevernieres changed the title Feature/update hashes Update gdas.cd Oct 7, 2024
@guillaumevernieres
Copy link
Contributor Author

@guillaumevernieres , the hash for sorc/gdas.cd can be updated. GDASApp PR #1310 was merged into develop at 9d95c9d.

Thanks @RussTreadon-NOAA , working on it this morning.

@guillaumevernieres guillaumevernieres marked this pull request as ready for review October 7, 2024 13:21
CoryMartin-NOAA
CoryMartin-NOAA previously approved these changes Oct 7, 2024
View reviewed changes
aerorahul
aerorahul previously approved these changes Oct 7, 2024
View reviewed changes
@aerorahul aerorahul added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS labels Oct 7, 2024
@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS labels Oct 7, 2024
@emcbot
Copy link

emcbot commented Oct 26, 2024

Experiment C48_S2SWA_gefs FAILED on Hercules in Build# 5 in
/work/noaa/stmp/CI/HERCULES/2978/RUNTESTS/EXPDIR/

@emcbot
Copy link

emcbot commented Oct 26, 2024

Experiment C96_atm3DVar FAILED on Hercules in Build# 5 in
/work/noaa/stmp/CI/HERCULES/2978/RUNTESTS/EXPDIR/

@emcbot
Copy link

emcbot commented Oct 26, 2024

Experiment C48_S2SW FAILED on Hercules in Build# 5 in
/work/noaa/stmp/CI/HERCULES/2978/RUNTESTS/EXPDIR/

@emcbot emcbot added CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed and removed CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed labels Oct 26, 2024
@WalterKolczynski-NOAA
Copy link
Contributor

stmp on /work is also full. Needs to be /work2/noaa/global/CI/HERCULES like I requested.

@WalterKolczynski-NOAA WalterKolczynski-NOAA removed the CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed label Oct 26, 2024
@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules label Oct 26, 2024
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules labels Oct 26, 2024
@RussTreadon-NOAA
Copy link
Contributor

@WalterKolczynski-NOAA . I failed to correctly read your message. 17cf1eb commits the change you requested. custom_workspace is now set to /work2/noaa/global for Hercules in ci/Jenkinsfile

@RussTreadon-NOAA
Copy link
Contributor

@WalterKolczynski-NOAA , feel free to edit ci/Jenkinsfile in guillaumevernieres:feature/update_hashes as you wish. This isn't a file users should normally edit, right?

@emcbot emcbot added CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed and removed CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Oct 26, 2024
@emcbot
Copy link

emcbot commented Oct 26, 2024

Experiment C96C48_hybatmDA FAILED on Hercules in Build# 6 in
/work2/noaa/global/CI/HERCULES/2978/RUNTESTS/EXPDIR/

@emcbot
Copy link

emcbot commented Oct 26, 2024

Experiment C48_ATM FAILED on Hercules in Build# 6 in
/work2/noaa/global/CI/HERCULES/2978/RUNTESTS/EXPDIR/

@emcbot
Copy link

emcbot commented Oct 26, 2024

Experiment C48_S2SWA_gefs FAILED on Hercules in Build# 6 in
/work2/noaa/global/CI/HERCULES/2978/RUNTESTS/EXPDIR/

@emcbot
Copy link

emcbot commented Oct 26, 2024

Experiment C96_S2SWA_gefs_replay_ics FAILED on Hercules in Build# 6 in
/work2/noaa/global/CI/HERCULES/2978/RUNTESTS/EXPDIR/

@emcbot
Copy link

emcbot commented Oct 26, 2024

Experiment C48_S2SW FAILED on Hercules in Build# 6 in
/work2/noaa/global/CI/HERCULES/2978/RUNTESTS/EXPDIR/

@emcbot
Copy link

emcbot commented Oct 26, 2024

Experiment C96_atm3DVar FAILED on Hercules in Build# 6 in
/work2/noaa/global/CI/HERCULES/2978/RUNTESTS/EXPDIR/

@emcbot emcbot added CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed and removed CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed labels Oct 26, 2024
@WalterKolczynski-NOAA
Copy link
Contributor

Okay, there are other issues with CI going on beyond just full drives. Going to go ahead and merge this. Will keep the new CI location, so there are fewer people to harangue to clean up space when we run out.

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 2fdfaa5 into NOAA-EMC:develop Oct 26, 2024
9 of 11 checks passed
@RussTreadon-NOAA
Copy link
Contributor

Thanks you @WalterKolczynski-NOAA for merging this PR into develop.

@RussTreadon-NOAA RussTreadon-NOAA mentioned this pull request Oct 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

@AndrewEichmann-NOAA AndrewEichmann-NOAA AndrewEichmann-NOAA left review comments

@danholdaway danholdaway danholdaway left review comments

@RussTreadon-NOAA RussTreadon-NOAA RussTreadon-NOAA left review comments

@aerorahul aerorahul aerorahul left review comments

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA left review comments

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA Awaiting requested review from TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA is a code owner

Assignees
No one assigned
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.