Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation of PyGnome fails due to missing dependency: GitPython #126

Open
lukecampbell opened this issue Aug 3, 2022 · 2 comments
Open

Comments

@lukecampbell
Copy link

Summary

Following the steps in the Installation.rst for the develop branch, fails to install the project due to a ModuleNotFoundError

Steps to reproduce

Check out the project's develop branch (commit as of this issue 4207283f2806ff455001c00e66da66031f17889d)

conda create --name test_env --file conda_requirements.txt
conda activate test_env
cd py_gnome
python setup.py develop

Results in

Traceback (most recent call last):
  File "/home/luke/code/PyGnome/py_gnome/setup.py", line 32, in <module>
    from git import Repo
ModuleNotFoundError: No module named 'git'

Expectations

I will know this is fixed when no exception is raised when running setup.py and it correctly builds the package and installs it.

Notes

The only reason I didn't issue a PR with GitPython appended in the conda_requirements.txt is I don't know for certain that GitPython is the right dependency, since there's a bunch out there.

@ChrisBarker-NOAA
Copy link
Contributor

we've split out the requirments files -- you need:

conda_requirements_build.txt

conda_requirements_build.txt

I thought I'd updated the docs, but maybe that update hasn't gotten pushed to gitHub yet -- stay tuned.

-CHB

@ChrisBarker-NOAA
Copy link
Contributor

OK -- develop branch updated -- and the docs are now correct (I hope :-) )

Thanks,

-CHB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants