-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forcing value for specific humidity being set to what appears to be a precipitation variable. #26
Comments
@hellkite500, it gets weirder. Look at aorc.c line 44. I think these aorc routines are worth a closer look as I believe they're adaptations of adaptations. The fully functionality isn't even used in CFE. |
@SnowHydrology I didn't think there were used anywhere, but I noticed this bug looking at something completely different and wanted to document it. I didn't look too far down the function to see what else it was doing. |
In the original t-shirt.c code, it was:
float specific_humidity_2m_kg_per_kg; // Specific Humidity at 2m height,
kg/kg | SPFH_2maboveground
…On Thu, Oct 21, 2021 at 1:01 PM Nels ***@***.***> wrote:
@SnowHydrology <https://github.com/SnowHydrology> I didn't think there
were used anywhere, but I noticed this bug looking at something completely
different and wanted to document it. I didn't look too far down the
function to see what else it was doing.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#26 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACA4SRJAYZZ4WBG34TBKDYTUIBINPANCNFSM5GOTK43A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
@hellkite500 & @SnowHydrology Thats is my mistake. This stuff isn't used. I just copied it from https://github.com/NOAA-OWP/ngen/tree/master/models/kernels/evapotranspiration and made it work for BMI. Just must have made a copy/paste error. |
This happens in both aorc.c line 33 and in pet.c line 49
The text was updated successfully, but these errors were encountered: