Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forcing value for specific humidity being set to what appears to be a precipitation variable. #26

Open
hellkite500 opened this issue Oct 21, 2021 · 4 comments

Comments

@hellkite500
Copy link
Member

This happens in both aorc.c line 33 and in pet.c line 49

@SnowHydrology
Copy link
Contributor

@hellkite500, it gets weirder. Look at aorc.c line 44. I think these aorc routines are worth a closer look as I believe they're adaptations of adaptations. The fully functionality isn't even used in CFE.

@hellkite500
Copy link
Member Author

@SnowHydrology I didn't think there were used anywhere, but I noticed this bug looking at something completely different and wanted to document it. I didn't look too far down the function to see what else it was doing.

@stcui007
Copy link
Contributor

stcui007 commented Oct 21, 2021 via email

@jmframe
Copy link
Contributor

jmframe commented Nov 5, 2021

@hellkite500 & @SnowHydrology Thats is my mistake. This stuff isn't used. I just copied it from https://github.com/NOAA-OWP/ngen/tree/master/models/kernels/evapotranspiration and made it work for BMI. Just must have made a copy/paste error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants