Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model binary is not correctly resolved #167

Open
aaraney opened this issue Aug 15, 2024 · 0 comments
Open

Model binary is not correctly resolved #167

aaraney opened this issue Aug 15, 2024 · 0 comments
Assignees
Labels
bug Something isn't working ngen.cal Related to ngen.cal package

Comments

@aaraney
Copy link
Member

aaraney commented Aug 15, 2024

Related to #85

self._model = Model(model=model_conf, binary=resolved_binary)

binary is not a field on Model, so this is a no-op.

Fix:

Check if binary is an absolute path and resolve if it is. This still allows advanced use of the binary field.

@aaraney aaraney added bug Something isn't working ngen.cal Related to ngen.cal package labels Aug 15, 2024
@aaraney aaraney self-assigned this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ngen.cal Related to ngen.cal package
Projects
None yet
Development

No branches or pull requests

1 participant